This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
Remove producer and viewer clients from pipeline tests #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-bcom
reviewed
Jul 23, 2021
| SRef<Image> image = images[INDEX_USE_CAMERA]; | ||
| Transform3Df pose = poses[INDEX_USE_CAMERA]; | ||
| // display image | ||
| if (gImageViewer->display(image) != FrameworkReturnCode::_SUCCESS) break; |
There was a problem hiding this comment.
LOG_ERROR ? If it's an error, this path should not lead to return 0.
jim-bcom
reviewed
Jul 23, 2021
| std::vector<SRef<CloudPoint>> pointCloud; | ||
| std::vector<Transform3Df> keyframePoses; | ||
| if (gMappingPipeline->getDataForVisualization(pointCloud, keyframePoses) == FrameworkReturnCode::_SUCCESS) { | ||
| if (g3DViewer->display(pointCloud, keyframePoses[keyframePoses.size() - 1], keyframePoses) != FrameworkReturnCode::_SUCCESS) |
jim-bcom
reviewed
Jul 23, 2021
| @@ -17,6 +17,7 @@ | |||
| #include <boost/log/core.hpp> | |||
| #include <boost/thread/thread.hpp> | |||
| #include <signal.h> | |||
| #include <thread> | |||
There was a problem hiding this comment.
I think this comes from my previous commit, check whether you can remove it.
jim-bcom
reviewed
Jul 23, 2021
| @@ -17,6 +17,7 @@ | |||
| #include <boost/log/core.hpp> | |||
| #include <boost/thread/thread.hpp> | |||
| #include <signal.h> | |||
| #include <thread> | |||
There was a problem hiding this comment.
Same as before, maybe from my previous commit, see if you can get rid of it.
jim-bcom
reviewed
Jul 23, 2021
| SRef<Image> image = images[INDEX_USE_CAMERA]; | ||
| Transform3Df pose = poses[INDEX_USE_CAMERA]; | ||
| // display image | ||
| if (gImageViewer->display(image) != FrameworkReturnCode::_SUCCESS) break; |
jim-bcom
reviewed
Jul 23, 2021
| std::vector<SRef<CloudPoint>> pointCloud; | ||
| std::vector<Transform3Df> keyframePoses; | ||
| if (gMappingPipeline->getDataForVisualization(pointCloud, keyframePoses) == FrameworkReturnCode::_SUCCESS) { | ||
| if (g3DViewer->display(pointCloud, keyframePoses[keyframePoses.size() - 1], keyframePoses) != FrameworkReturnCode::_SUCCESS) |
…pressing escape. Fix .pro to install correct config files
… folder. Fix map visualization of pipeline tests
jim-bcom
reviewed
Jul 26, 2021
...line_Mapping_Mono/tests/SolARPipelineTest_Mapping_Mono/SolARPipelineTestMappingMono_main.cpp
Show resolved
Hide resolved
jim-bcom
reviewed
Jul 26, 2021
...line_Mapping_Mono/tests/SolARPipelineTest_Mapping_Mono/SolARPipelineTestMappingMono_main.cpp
Show resolved
Hide resolved
jim-bcom
reviewed
Jul 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.